-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8361370: runtime/Thread/TestThreadDumpMonitorContention.java fails due to time out on Windows #26895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into |
@toxaart This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
Thanks for adding the comment. I leave this up to the serviceability devs to finalize the review. Maybe @sspitsyn or @plummercj could help out given that they reviewed JDK-8354461. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussions in JBS this change to the test seems fine. Some minor edits on the comment needed.
Thanks.
test/hotspot/jtreg/runtime/Thread/TestThreadDumpMonitorContention.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Hi, please consider the following changes:
Jstack streaming output should be disabled in the test as JDK-8354461 suggest.
When disabled, the test does not hang with ZGC enabled.
Tested locally.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26895/head:pull/26895
$ git checkout pull/26895
Update a local copy of the PR:
$ git checkout pull/26895
$ git pull https://git.openjdk.org/jdk.git pull/26895/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26895
View PR using the GUI difftool:
$ git pr show -t 26895
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26895.diff
Using Webrev
Link to Webrev Comment